![rofl0r](/assets/img/avatar_default.png)
due to the usage of a hashmap to store headers, when relaying them to the other side the order was not prevented. even though correct from a standards point-of-view, this caused issues with various programs, and it allows to fingerprint the use of tinyproxy. to implement this, i imported the MIT-licensed hsearch.[ch] from https://github.com/rofl0r/htab which was originally taken from musl libc. it's a simple and efficient hashtable implementation with far better performance characteristic than the one previously used by tinyproxy. additionally it has an API much more well-suited for this purpose. orderedmap.[ch] was implemented from scratch to address this issue. behind the scenes it uses an sblist to store string values, and a htab to store keys and the indices into the sblist. this allows us to iterate linearly over the sblist and then find the corresponding key in the hash table, so the headers can be reproduced in the order they were received. closes #73
22 lines
514 B
C
22 lines
514 B
C
#ifndef HSEARCH_H
|
|
#define HSEARCH_H
|
|
|
|
#include <stdlib.h>
|
|
|
|
typedef union htab_value {
|
|
void *p;
|
|
size_t n;
|
|
} htab_value;
|
|
|
|
#define HTV_N(N) (htab_value) {.n = N}
|
|
#define HTV_P(P) (htab_value) {.p = P}
|
|
|
|
struct htab * htab_create(size_t);
|
|
void htab_destroy(struct htab *);
|
|
htab_value* htab_find(struct htab *, const char* key);
|
|
int htab_insert(struct htab *, char*, htab_value);
|
|
int htab_delete(struct htab *htab, const char* key);
|
|
size_t htab_next(struct htab *, size_t iterator, char** key, htab_value **v);
|
|
|
|
#endif
|