bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reqs: Fix CID 1130967 - unchecked return value from library.

Browse Source 
Check the return code of fcntl via socket_blocking
in pull_client_data().

Found by coverity.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 0a99803425)
This commit is contained in:
Michael Adam 2013-11-22 18:30:30 +01:00
parent 9eec142886
commit 6c8d9de3cc
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/reqs.c
View File

@ -527,7 +527,13 @@ static int pull_client_data (struct conn_s *connptr, long int length)
*/
socket_nonblocking (connptr->client_fd);
len = recv (connptr->client_fd, buffer, 2, MSG_PEEK);
socket_blocking (connptr->client_fd);
ret = socket_blocking (connptr->client_fd);
if (ret != 0) {
log_message(LOG_ERR, "Failed to set the client socket "
"to blocking: %s", strerror(errno));
goto ERROR_EXIT;
}
if (len < 0 && errno != EAGAIN)
goto ERROR_EXIT;