bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve clarity of error message in case of wrong proxy server password

Browse Source 
why not be real user friendly and tell them where to get the password from and what the exact name of the password is. 
being not helpful just gives tinyproxy a bad name... ;-)
This commit is contained in:
n3mxnet 2019-06-28 15:47:28 +02:00 committed by GitHub
parent 734ba1d970
commit 62c16c02bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/reqs.c
View File

@ -1641,7 +1641,7 @@ void handle_connection (int fd)
failure = 0;
if(failure) {
e401:
update_stats (STAT_DENIED);
update_stats (STAT_DENIED);
indicate_http_error (connptr, 401, "Unauthorized",
"detail",
"The administrator of this proxy has not configured "
@ -1651,7 +1651,7 @@ e401:
}
hashmap_remove (hashofheaders, "proxy-authorization");
}
/* above we should try to clarify it to even newbie users that their proxy password is what is wrong most likely here and actually tell him what to do about it. Those succint error msg drive ppl crazy */
/*
* Add any user-specified headers (AddHeader directive) to the
* outgoing HTTP request.