bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

child: Fix CID 1130966 - unchecked return value from library

Browse Source 
check the return code of fcntl via socket_nonblocking
on the listen sockets in child_main()

Found by coverity.

Signed-off-by: Michael Adam <obnox@samba.org>
This commit is contained in:
Michael Adam 2013-11-22 18:37:43 +01:00
parent 0a99803425
commit 38ef36d998
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/child.c
View File

@ -211,7 +211,14 @@ static void child_main (struct child_s *ptr)
for (i = 0; i < vector_length(listen_fds); i++) { for (i = 0; i < vector_length(listen_fds); i++) {
int *fd = (int *) vector_getentry(listen_fds, i, NULL); int *fd = (int *) vector_getentry(listen_fds, i, NULL);
socket_nonblocking(*fd); ret = socket_nonblocking(*fd);
if (ret != 0) {
log_message(LOG_ERR, "Failed to set the listening "
"socket %d to non-blocking: %s",
fd, strerror(errno));
exit(1);
}
FD_SET(*fd, &rfds); FD_SET(*fd, &rfds);
maxfd = max(maxfd, *fd); maxfd = max(maxfd, *fd);
} }