bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reqs: Fix CID 1130969 (part 3) - unchecked return value from library.

Browse Source 
Check the return value of socket_blocking (fcntl) at the
end of relay_connection() for client socket.

Signed-off-by: Michael Adam <obnox@samba.org>
This commit is contained in:
Michael Adam 2013-11-22 21:56:39 +01:00
parent e07c363df2
commit 3710accf72
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/reqs.c
View File

@ -1210,7 +1210,14 @@ static void relay_connection (struct conn_s *connptr)
* Here the server has closed the connection... write the * Here the server has closed the connection... write the
* remainder to the client and then exit. * remainder to the client and then exit.
*/ */
socket_blocking (connptr->client_fd); ret = socket_blocking (connptr->client_fd);
if (ret != 0) {
log_message(LOG_ERR,
"Failed to set client socket to blocking: %s",
strerror(errno));
return;
}
while (buffer_size (connptr->sbuffer) > 0) { while (buffer_size (connptr->sbuffer) > 0) {
if (write_buffer (connptr->client_fd, connptr->sbuffer) < 0) if (write_buffer (connptr->client_fd, connptr->sbuffer) < 0)
break; break;