bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

transparent: remove usage of inet_ntoa(), make IPv6 ready

Browse Source 
inet_ntoa() uses a static buffer and is therefore not threadsafe.
additionally it has been deprecated by POSIX.

by using inet_ntop() instead the code has been made ipv6 aware.

note that this codepath was only entered in the unlikely event that
no hosts header was being passed to the proxy, i.e. pre-HTTP/1.1.
This commit is contained in:
rofl0r 2020-09-06 16:22:11 +01:00
parent 51b8be3ee4
commit 36c9b93cfe
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configure.ac
View File

@ -143,7 +143,7 @@ AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK
AC_FUNC_MALLOC AC_FUNC_MALLOC
AC_FUNC_REALLOC AC_FUNC_REALLOC
AC_CHECK_FUNCS([inet_ntoa strdup]) AC_CHECK_FUNCS([strdup])
AC_CHECK_FUNCS([strlcpy strlcat setgroups]) AC_CHECK_FUNCS([strlcpy strlcat setgroups])
dnl Enable extra warnings dnl Enable extra warnings

20
src/transparent-proxy.c
View File

@ -64,12 +64,16 @@ do_transparent_proxy (struct conn_s *connptr, hashmap_t hashofheaders,
length = hashmap_entry_by_key (hashofheaders, "host", (void **) &data); length = hashmap_entry_by_key (hashofheaders, "host", (void **) &data);
if (length <= 0) { if (length <= 0) {
struct sockaddr_in dest_addr; union sockaddr_union dest_addr;
const void *dest_inaddr;
char namebuf[INET6_ADDRSTRLEN+1];
int af;
length = sizeof(dest_addr); length = sizeof(dest_addr);
if (getsockname if (getsockname
(connptr->client_fd, (struct sockaddr *) &dest_addr, (connptr->client_fd, (void *) &dest_addr,
&length) < 0 || length > sizeof(dest_addr)) { &length) < 0 || length > sizeof(dest_addr)) {
addr_err:;
log_message (LOG_ERR, log_message (LOG_ERR,
"process_request: cannot get destination IP for %d", "process_request: cannot get destination IP for %d",
connptr->client_fd); connptr->client_fd);
@ -79,10 +83,16 @@ do_transparent_proxy (struct conn_s *connptr, hashmap_t hashofheaders,
return 0; return 0;
} }
request->host = (char *) safemalloc (17); af = length == sizeof(dest_addr.v4) ? AF_INET : AF_INET6;
strlcpy (request->host, inet_ntoa (dest_addr.sin_addr), 17); if (af == AF_INET) dest_inaddr = &dest_addr.v4.sin_addr;
else dest_inaddr = &dest_addr.v6.sin6_addr;
request->port = ntohs (dest_addr.sin_port); if (!inet_ntop(af, dest_inaddr, namebuf, sizeof namebuf))
goto addr_err;
request->host = safestrdup (namebuf);
request->port = ntohs (af == AF_INET ? dest_addr.v4.sin_port
: dest_addr.v6.sin6_port);
request->path = (char *) safemalloc (ulen + 1); request->path = (char *) safemalloc (ulen + 1);
strlcpy (request->path, *url, ulen + 1); strlcpy (request->path, *url, ulen + 1);