bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't ignore retval of write() in log.c

Browse Source
This commit is contained in:
Mukund Sivaraman 2009-09-23 07:18:23 +05:30
parent 616c03a9fb
commit 003df7454a
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/log.c
View File

@ -109,6 +109,8 @@ void log_message (int level, const char *fmt, ...)
char time_string[TIME_LENGTH]; char time_string[TIME_LENGTH];
char str[STRING_LENGTH]; char str[STRING_LENGTH];
ssize_t ret;
#ifdef NDEBUG #ifdef NDEBUG
/* /*
* Figure out if we should write the message or not. * Figure out if we should write the message or not.
@ -177,10 +179,25 @@ void log_message (int level, const char *fmt, ...)
assert (log_file_fd >= 0); assert (log_file_fd >= 0);
write (log_file_fd, str, strlen (str)); ret = write (log_file_fd, str, strlen (str));
if (ret == -1) {
log_message (LOG_WARNING,
"Could not write to log file");
}
vsnprintf (str, STRING_LENGTH, fmt, args); vsnprintf (str, STRING_LENGTH, fmt, args);
write (log_file_fd, str, strlen (str)); ret = write (log_file_fd, str, strlen (str));
write (log_file_fd, "\n", 1); if (ret == -1) {
log_message (LOG_WARNING,
"Could not write to log file");
}
ret = write (log_file_fd, "\n", 1);
if (ret == -1) {
log_message (LOG_WARNING,
"Could not write to log file");
}
fsync (log_file_fd); fsync (log_file_fd);
#ifdef HAVE_SYSLOG_H #ifdef HAVE_SYSLOG_H