bughz/tinyproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78e4a6d902
tinyproxy/src/mypoll.h

32 lines
494 B
C
Raw Normal View History

prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
#ifndef MYPOLL_H
#define MYPOLL_H
use poll() where available
2020-09-16 03:01:01 +08:00
#include "config.h"
prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
#ifdef HAVE_POLL_H
tune error messages to show select or poll depending on what is used
2020-09-18 04:03:51 +08:00
#define SELECT_OR_POLL "poll"
use poll() where available
2020-09-16 03:01:01 +08:00
prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
#include <poll.h>
typedef struct pollfd pollfd_struct;
use poll() where available
2020-09-16 03:01:01 +08:00
#define MYPOLL_READ POLLIN
#define MYPOLL_WRITE POLLOUT
prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
#else
use poll() where available
2020-09-16 03:01:01 +08:00
tune error messages to show select or poll depending on what is used
2020-09-18 04:03:51 +08:00
#define SELECT_OR_POLL "select"
use poll() where available
2020-09-16 03:01:01 +08:00
#include <sys/select.h>
prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
typedef struct mypollfd {
int fd;
short events;
short revents;
} pollfd_struct;
#define MYPOLL_READ (1<<1)
#define MYPOLL_WRITE (1<<2)
use poll() where available
2020-09-16 03:01:01 +08:00
#endif
prepare transition to poll() usage of select() is inefficient (because a huge fd_set array has to be initialized on each call) and insecure (because an fd >= FD_SETSIZE will cause out-of-bounds accesses using the FD_*SET macros, and a system can be set up to allow more than that number of fds using ulimit). for the moment we prepared a poll-like wrapper that still runs select() to test for regressions, and so we have fallback code for systems without poll().
2020-09-16 02:29:03 +08:00
int mypoll(pollfd_struct* fds, int nfds, int timeout);
#endif
Reference in New Issue Copy Permalink