bughz/sigar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

no need to FreeLibrary handle returned by GetModuleHandle

Browse Source
This commit is contained in:
Doug MacEachern 2007-03-08 01:59:08 +00:00
parent 1affc51534
commit 171f2e021e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/os/win32/win32_sigar.c
View File

@ -1354,6 +1354,10 @@ static int sigar_remote_proc_env_get(sigar_t *sigar, sigar_pid_t pid,
LPVOID addr; LPVOID addr;
int status; int status;
/*
* Do not FreeLibrary(kdll), see:
* http://msdn2.microsoft.com/en-us/library/ms683199.aspx
*/
if (!(kdll = GetModuleHandle("msvcrt.dll"))) { if (!(kdll = GetModuleHandle("msvcrt.dll"))) {
return GetLastError(); return GetLastError();
} }
@ -1370,8 +1374,6 @@ static int sigar_remote_proc_env_get(sigar_t *sigar, sigar_pid_t pid,
return GetLastError(); return GetLastError();
} }
/* FIXME: close the kdll handles */
if (!(proc = OpenProcess(MAXIMUM_ALLOWED, 0, (DWORD)pid))) { if (!(proc = OpenProcess(MAXIMUM_ALLOWED, 0, (DWORD)pid))) {
return GetLastError(); return GetLastError();
} }