From 171f2e021e3359ee5d83600f753f64bc2da4d22f Mon Sep 17 00:00:00 2001 From: Doug MacEachern Date: Thu, 8 Mar 2007 01:59:08 +0000 Subject: [PATCH] no need to FreeLibrary handle returned by GetModuleHandle --- src/os/win32/win32_sigar.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/os/win32/win32_sigar.c b/src/os/win32/win32_sigar.c index 9763ecb1..8c40d14c 100644 --- a/src/os/win32/win32_sigar.c +++ b/src/os/win32/win32_sigar.c @@ -1354,6 +1354,10 @@ static int sigar_remote_proc_env_get(sigar_t *sigar, sigar_pid_t pid, LPVOID addr; int status; + /* + * Do not FreeLibrary(kdll), see: + * http://msdn2.microsoft.com/en-us/library/ms683199.aspx + */ if (!(kdll = GetModuleHandle("msvcrt.dll"))) { return GetLastError(); } @@ -1370,8 +1374,6 @@ static int sigar_remote_proc_env_get(sigar_t *sigar, sigar_pid_t pid, return GetLastError(); } - /* FIXME: close the kdll handles */ - if (!(proc = OpenProcess(MAXIMUM_ALLOWED, 0, (DWORD)pid))) { return GetLastError(); }