Commit Graph

3089 Commits

Author SHA1 Message Date
Asher 4abc525801
Update cross-build image apt before installing (#4411) 2021-10-28 15:36:21 -07:00
Joe Previte 705e821741
fix(testing): revert change & fix playwright tests (#4310)
* fix(testing): revert change & fix playwright tests

* fix(constants): add type to import statement

* refactor(e2e): delete browser test

This test was originally added to ensure playwright was working.

At this point, we know it works so removing this test because it doesn't help
with anything specific to code-server and only adds unnecessary code to the
codebase plus increases the e2e test job duration.

* chore(e2e): use 1 worker for e2e test

I don't know if it's a resources issue, playwright, or code-server but it seems
like the e2e tests choke when multiple workers are used.

This change is okay because our CI runner only has 2 cores so it would only use
1 worker anyway, but by specifying it in our playwright config, we ensure more
stability in our e2e tests working correctly.

See these PRs:
- https://github.com/cdr/code-server/pull/3263
- https://github.com/cdr/code-server/pull/4310

* revert(vscode): add missing route with redirect

* chore(vscode): update to latest fork

* Touch up compilation step.

* Bump vendor.

* Fix VS Code minification step

* Move ClientConfiguration to common

Common code must not import Node code as it is imported by the browser.

* Ensure lib directory exists before curling

cURL errors now because VS Code was moved and the directory does not
exist.

* Update incorrect e2e test help output

Revert workers change as well; this can be overridden when desired.

* Add back extension compilation step

* Include missing resources in release

This includes a favicon, for example.  I opted to include the entire
directory to make sure we do not miss anything.  Some of the other
stuff looks potentially useful (like completions).

* Set quality property in product configuration

When httpWebWorkerExtensionHostIframe.html is fetched it uses the web
endpoint template (in which we do not include the commit) but if the
quality is not set it prepends the commit to the web endpoint instead.
The new static endpoint does not use/handle commits so this 404s.

Long-term we might want to make the new static endpoint use commits like
the old one but we will also need to update the various other static
URLs to include the commit.

For now I just fixed this by adding the quality since:
  1. Probably faster than trying to find and update all static uses.
  2. VS Code probably expects it anyway.
  3. Gives us better control over the endpoint.

* Update VS Code

This fixes several build issues.

* Bump vscode.

* Bump.

* Bump.

* Use CLI directly.

* Update tests to reflect new upstream behavior.

* Move unit tests to after the build

Our code has new dependencies on VS Code that are pulled in when the
unit tests run.  Because of this we need to build VS Code before running
the unit tests (as it only pulls built code).

* Upgrade proxy-agent dependencies

This resolves a security report with one of its dependencies (vm2).

* Symlink VS Code output directory before unit tests

This is necessary now that we import from the out directory.

* Fix issues surrounding persistent processes between tests.

* Update VS Code cache directories

These were renamed so the cached paths need to be updated.  I changed
the key as well to force a rebuild.

* Move test symlink to script

This way it works for local testing as well.

I had to use out-build instead of out-vscode-server-min because Jest
throws some obscure error about a handlebars haste map.

* Fix listening on a socket

* Update VS Code

It contains fixes for missing files in the build.

* Standardize disposals

* Dispose HTTP server

Shares code with the test HTTP server.  For now it is a function but
maybe we should make it a class that is extended by tests.

* Dispose app on exit

* Fix logging link errors

Unfortunately the logger currently chokes when provided with error
objects.

Also for some reason the bracketed text was not displaying...

* Update regex used by e2e to extract address

The address was recently changed to use URL which seems to add a
trailing slash when using toString, causing the regex match to fail.

* Log browser console in e2e tests

* Add base back to login page

This is used to set cookies when using a base path.

* Remove login page test

The file this was testing no longer exists.

* Use path.posix for static base

Since this is a web path and not platform-dependent.

* Add test for invalid password

Co-authored-by: Teffen Ellis <teffen@nirri.us>
Co-authored-by: Asher <ash@coder.com>
2021-10-28 15:27:17 -05:00
Mr. Blogger 0e97a94acf
Replace nodejs with nodejs-lts in Termux docs (#4336)
nodejs installs v16 which is not compatible.  nodejs-lts currently uses v14.
2021-10-25 11:14:37 -05:00
Asher 3520ad2286
Mention that Safari needs TLS 1.2 (#4346)
* Mention that Safari needs TLS 1.2

https://github.com/cdr/code-server/issues/3850

* Delete duplicated guide sections
2021-10-18 10:31:30 -05:00
McChen ad17c7dc8e
docs: fix nfpm link in contributing (#4369)
Co-authored-by: chenjiahao <chenjiahao@jd.com>
2021-10-18 10:25:42 -05:00
Joe Previte 271bc06754
Merge pull request #4309 from cdr/jsjoeio-test-monday
feat(cli): add tests for password, hashed-password
2021-10-05 11:14:07 -07:00
Ben Potter dfc505b977
Merge pull request #4307 from cdr/bpmct/comparison
update comparisons in FAQ
2021-10-05 12:24:58 -05:00
Ben Potter ee1de79af6
fix weird format 2021-10-05 11:40:57 -05:00
Ben Potter fa6f47965a
Update docs/FAQ.md
Co-authored-by: Ashley McClelland <ashley@coder.com>
2021-10-05 11:31:40 -05:00
Ben Potter 1af83a3c56
Update docs/FAQ.md
Co-authored-by: Ashley McClelland <ashley@coder.com>
2021-10-05 11:31:34 -05:00
Ben Potter 8745f1aa63
Update docs/FAQ.md
Co-authored-by: Ashley McClelland <ashley@coder.com>
2021-10-05 11:31:29 -05:00
Ben Potter bb1799ba04
Update docs/FAQ.md
Co-authored-by: Ashley McClelland <ashley@coder.com>
2021-10-05 11:31:24 -05:00
Ben Potter 70fbfc7ada
Update docs/FAQ.md
Co-authored-by: Ashley McClelland <ashley@coder.com>
2021-10-05 11:31:17 -05:00
Tian Jian 59f667ec14
Fix: use pipe to spawn child process to re-enable file logging (#4293)
We pipe the child's stdout and stderr to the log file (and to the parent's streams) but since we used `inherit` for `stdio` this caused the child to use the parent's streams directly which made `child.stdout` and `child.stderr` non-existent and thus we had no file logging.

Using `pipe` creates stdin and stderr on the child.
2021-10-05 10:55:40 -05:00
Ben Potter 816152ddbd
fix typo 2021-10-04 17:41:36 -05:00
Joe Previte 45319ec648
woo! 2021-10-04 15:04:07 -07:00
Joe Previte e588f8b0b0
feat(cli): add tests for password, hashed-password 2021-10-04 14:51:14 -07:00
Ben Potter 7c26a82a17
format 2021-10-04 14:57:58 -05:00
Ben Potter 75e44fdc84
update comparisons in FAQ 2021-10-04 14:48:31 -05:00
Joe Previte 8a4ed5a2e0
Merge pull request #4306 from cdr/jsjoeio-fix-broken-tests
fix: revert CI change + fix broken tests
2021-10-04 12:20:31 -07:00
Joe Previte a8d873f9f8
refactor(ci): fix unit tests job 2021-10-04 12:07:45 -07:00
Joe Previte 7183b5a43e
chore(testing): fix casing in error messsage 2021-10-04 12:06:33 -07:00
Joe Previte 8136769b66
fix: close vscodeServer on server close if defined 2021-10-04 12:06:12 -07:00
Teffen Ellis 672038c6af Fix issue where marketplace is undefined.
- Fix error logging from child process.
2021-10-04 13:26:16 -04:00
Joe Previte 2d7aeb5bf9
Merge pull request #4290 from cdr/jsjoeio-vscode
chore(vscode): update to latest commit of fork
2021-10-01 14:57:02 -07:00
Joe Previte f342c327f3
chore(vscode): update to latest commit of fork 2021-10-01 14:47:20 -07:00
Joe Previte 4619786019
Merge pull request #4274 from cdr/jsjoeio-testing-guidelines
docs: update section around testing
2021-10-01 11:15:15 -07:00
Joe Previte 1dfcd0448e
Merge pull request #4273 from cdr/jsjoeio-bump-helm-chart
chore(helm-chart): bump to 1.0.5
2021-10-01 11:10:21 -07:00
Joe Previte 48ce49eec8
Merge pull request #4281 from toddewilliams/patch-1
Update collaboration.md
2021-09-30 16:43:48 -07:00
Teffen Ellis d8c344beda Refactor vscode endpoints to use fork directly. 2021-09-30 19:14:17 -04:00
Teffen Ellis beebf53adc Add linkup command to improve link functionality 2021-09-30 19:14:17 -04:00
Joe Previte a14fa862da
fixup! Update collaboration.md 2021-09-30 15:23:16 -07:00
Todd Williams fc0d127470
Update collaboration.md
I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail. 

I made no changes to the other sections.
2021-09-30 11:51:42 -05:00
Joe Previte 6eda7ae81f
Merge pull request #4243 from cdr/renovate/ws-8.x
chore(deps): update dependency @types/ws to v8
2021-09-29 15:17:58 -07:00
Joe Previte 3f75aa2db1
Merge pull request #4254 from cdr/ipad-copy-paste
iPad docs: add copy & paste known issue
2021-09-29 15:11:20 -07:00
Renovate Bot 328b864534
chore(deps): update dependency @types/ws to v8 2021-09-29 22:06:02 +00:00
Ben Potter 876d0275b3
iPad docs: add copy & paste known issue 2021-09-29 15:04:51 -07:00
Joe Previte b9989ca2db
docs(MAINTAINING): add Testing section 2021-09-29 15:02:11 -07:00
Joe Previte 4e310b4985
docs(CONTRIBUTING): add scrip tests section 2021-09-29 15:02:11 -07:00
Joe Previte d54b4accac
fix 2021-09-29 14:39:48 -07:00
Joe Previte 5e7b419820
chore: bump helm-chart version to 1.0.5
We've had two patches to the helm-chart since the last time we bumped the Chart
version.

- 1ffca5751c
- 5a36627aae

This version bump ensures that chart version has the correct date.
2021-09-29 14:38:13 -07:00
Joe Previte 1b80244af7
Merge pull request #4265 from cdr/jsjoeio-add-tests
feat(cli): add test for defaultConfigFile
2021-09-28 16:19:32 -07:00
Joe Previte 999960eef5
Merge pull request #4236 from cdr/jsjoeio/fix-brew-bump
fix(brew-bump.sh): add checks and handle errors
2021-09-28 16:13:24 -07:00
Joe Previte 6c95f72d2b
refactor: make password param to defaultConfigFile 2021-09-28 16:13:13 -07:00
Joe Previte 8ef950af4c
feat(brew-bump): add check for cleanup step 2021-09-28 16:07:01 -07:00
Joe Previte e5f03e0b06
fix: add checks and handle errors brew-bump.sh
feat(script): add steps-lib, is_env_var_set & test

feat(brew-bump): add check for VERSION

feat(brew-bump): check HOMEBREW_GITHUB_API_TOKEN

feat(steps-lib): add directory_exists helper fn

fix(brew-bump): check that git clone worked

feat(brew-bump): add check for remote upstream

fix: remove upstream command thing

feat(steps-lib): add file_exists helper function

feat(brew-bump): add check for git-askpass.sh

feat(steps-lib): add is_executable function & test

feat(brew-bump): add check for is_executable

refactor: use GIT_ASKPASS as variable
2021-09-28 16:06:57 -07:00
Joe Previte 77c1150b8d
feat(cli): add test for defaultConfigFile 2021-09-28 15:45:44 -07:00
Joe Previte fb2625dbe8
chore(cli): export defaultConfigFile + add JSDoc 2021-09-28 15:38:59 -07:00
Joe Previte 82d93186f8
feat(cli): add test for defaultConfigFile 2021-09-28 14:41:38 -07:00
Jonathan Yu 8f72481712
chore: upgrade preview Node.js from 12 to 14 (#4255) 2021-09-28 09:21:39 -07:00