Windows: an error set where socket errors are read

errno is WSAGetLastError() on Windows, but seterrno3() set the C library's errno there: the EAGAIN of a TLS read or write wanting the socket again was not seen as one, and the error left was whatever the socket call before had set. seterrno3() sets the socket error now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
connlim: a connection's slot given back once
2026-11-16 06:05:50 +08:00 · 2026-10-27 15:11:24 +03:00 · 2026-10-27 00:03:33 +03:00
3 changed files with 6 additions and 1 deletions
--- a/src/mainclient.c
+++ b/src/mainclient.c
@ -419,7 +419,9 @@ void releaseparam(struct clientparam * param) {
 		if(param->filters[param->nfilters].filter->filter_clear)
 			(*param->filters[param->nfilters].filter->filter_clear)(param->filters[param->nfilters].data);
 	}
+	/* once: a second release must not give the slot back again */
 	if(param->connlim) stopconnlims(param);
+	param->connlim = 0;
 	/* a slot held in the newest service on the listener after a reload */
 	if(param->newsrv){
 		slotrelease(param->newsrv);
--- a/src/mainudp.c
+++ b/src/mainudp.c
@ -433,7 +433,9 @@ static void udpadopt(struct udpstate *st){
 		if(param->filters[param->nfilters].filter->filter_clear)
 			(*param->filters[param->nfilters].filter->filter_clear)(param->filters[param->nfilters].data);
 	}
+	/* counted again by the new service's authorization */
 	if(param->connlim) stopconnlims(param);
+	param->connlim = 0;
 	param->bandlimfunc = NULL;
 	param->bandlims[0] = param->bandlimsout[0] = NULL;
 	param->trafcountfunc = NULL;
--- a/src/proxy.h
+++ b/src/proxy.h
@ -182,7 +182,8 @@ size_t threadstacksize(int extra);
 #ifndef strncasecmp
 #define strncasecmp strnicmp
 #endif
-#define seterrno3(x) _set_errno(x)
+/* errno is WSAGetLastError() here */
+#define seterrno3(x) WSASetLastError(x)
 #else
 #define seterrno3(x) (errno = x) 
 #endif
Author	SHA1	Message	Date
Vladimir Dubrovin	982536b389	Windows: an error set where socket errors are read Some checks failed C/C++ CI Linux / ${{ matrix.target }} (ubuntu-24.04-arm) (push) Has been cancelled Details C/C++ CI Linux / ${{ matrix.target }} (ubuntu-latest) (push) Has been cancelled Details C/C++ CI MacOS / ${{ matrix.target }} (macos-15) (push) Has been cancelled Details C/C++ CI Windows / ${{ matrix.target }} (windows-2022) (push) Has been cancelled Details C/C++ CI cmake / ${{ matrix.target }} (macos-15) (push) Has been cancelled Details C/C++ CI cmake / ${{ matrix.target }} (ubuntu-24.04-arm) (push) Has been cancelled Details C/C++ CI cmake / ${{ matrix.target }} (ubuntu-latest) (push) Has been cancelled Details C/C++ CI cmake / ${{ matrix.target }} (windows-2022) (push) Has been cancelled Details C/C++ CI cmake / ubuntu-latest (wolfSSL) (push) Has been cancelled Details errno is WSAGetLastError() on Windows, but seterrno3() set the C library's errno there: the EAGAIN of a TLS read or write wanting the socket again was not seen as one, and the error left was whatever the socket call before had set. seterrno3() sets the socket error now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-27 15:11:24 +03:00
Vladimir Dubrovin	bd4db18413	connlim: a connection's slot given back once releaseparam() gave the connection limits' slot back without clearing param->connlim: a second call, made on the event loops' end of a relayed client, gave it back again, letting one more connection in for each such end while another held its slot, or, with no connlimconf, followed param->srv, cleared by the first call. It is cleared now. A UDP session taken over by the new service on a reload gave its slot back but kept connlim set, so the new service's authorization did not count it, and its end gave it back a second time. It is counted again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-27 00:03:33 +03:00