mirror of
https://github.com/3proxy/3proxy.git
synced 2026-11-22 23:59:41 +08:00
Fix memory leaks found under AddressSanitizer
- readconfig() kept its line buffer and argument array on every error return, so each refused reload leaked them. - A filter refusing a connection in filter_client (TLS: a failed handshake) was not kept, so its filter_clear never ran and the state it made was lost. makefilters() now clears it, and empties the slot first: a pooled worker's slot may hold the previous connection's. - ssl_filter_close() freed the client CA paths but not the server ones, for every TLS service set up. - Compiled patterns were never freed: an ACL's (pcre: and regex: host names), an httpsrv rule's. copyacl() shared them between the configuration's ACL and each service's copy; each copy now compiles its own, and freeacl() and freehttprules() free them. What LeakSanitizer still reports is OpenSSL's per-thread random generator state of pooled threads, released only by OpenSSL at exit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
1a193eb82d
commit
796e9f8156
4 files changed
+46
-6
No files matched your search
@@ -1122,6 +1122,10 @@ void freehttprules(struct httprule *rule)
|
||||
next = rule->next;
|
||||
if(rule->host.name) free(rule->host.name);
|
||||
if(rule->url.name) free(rule->url.name);
|
||||
#ifdef WITH_PCRE
|
||||
if(rule->host.re) pcre_pattern_free(rule->host.re);
|
||||
if(rule->url.re) pcre_pattern_free(rule->url.re);
|
||||
#endif
|
||||
if(rule->params) free(rule->params);
|
||||
if(rule->ctype) free(rule->ctype);
|
||||
if(rule->hdrs) free(rule->hdrs);
|
||||
|
||||
Reference in new issue
Block a user