[SIGAR-85] Fix possible integer overflow in sigar_file_system_usage

This commit is contained in:
Doug MacEachern 2008-02-01 00:56:05 +00:00
parent 073b439b2a
commit 7e422addb4
1 changed files with 10 additions and 6 deletions

View File

@ -1640,22 +1640,26 @@ int sigar_disk_usage_get(sigar_t *sigar, const char *name,
#include <sys/vfs.h> #include <sys/vfs.h>
#define SIGAR_FS_BLOCKS_TO_BYTES(buf, f) \ #define SIGAR_FS_BLOCKS_TO_BYTES(val, bsize) ((val * bsize) >> 1)
(((sigar_uint64_t)buf.f * (buf.f_bsize / 512)) >> 1)
int sigar_file_system_usage_get(sigar_t *sigar, int sigar_file_system_usage_get(sigar_t *sigar,
const char *dirname, const char *dirname,
sigar_file_system_usage_t *fsusage) sigar_file_system_usage_t *fsusage)
{ {
struct statfs buf; struct statfs buf;
sigar_uint64_t val, bsize;
if (statfs(dirname, &buf) != 0) { if (statfs(dirname, &buf) != 0) {
return errno; return errno;
} }
fsusage->total = SIGAR_FS_BLOCKS_TO_BYTES(buf, f_blocks); bsize = buf.f_bsize / 512;
fsusage->free = SIGAR_FS_BLOCKS_TO_BYTES(buf, f_bfree); val = buf.f_blocks;
fsusage->avail = SIGAR_FS_BLOCKS_TO_BYTES(buf, f_bavail); fsusage->total = SIGAR_FS_BLOCKS_TO_BYTES(val, bsize);
val = buf.f_bfree;
fsusage->free = SIGAR_FS_BLOCKS_TO_BYTES(val, bsize);
val = buf.f_bavail;
fsusage->avail = SIGAR_FS_BLOCKS_TO_BYTES(val, bsize);
fsusage->used = fsusage->total - fsusage->free; fsusage->used = fsusage->total - fsusage->free;
fsusage->files = buf.f_files; fsusage->files = buf.f_files;
fsusage->free_files = buf.f_ffree; fsusage->free_files = buf.f_ffree;