bughz
/
sigar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix integer overflow in sigar_uptime_string

This commit is contained in:
Doug MacEachern 2007-05-10 13:49:03 +00:00
parent 741c1ae7c5
commit 3fe0a04cc5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/sigar.c
View File

@ -279,17 +279,18 @@ SIGAR_DECLARE(int) sigar_uptime_string(sigar_t *sigar,
int buflen) int buflen)
{ {
char *ptr = buffer; char *ptr = buffer;
int time = (int)uptime->uptime;
int minutes, hours, days, offset = 0; int minutes, hours, days, offset = 0;
/* XXX: get rid of sprintf and/or check for overflow */ /* XXX: get rid of sprintf and/or check for overflow */
days = uptime->uptime / (60*60*24); days = time / (60*60*24);
if (days) { if (days) {
offset += sprintf(ptr + offset, "%d day%s, ", offset += sprintf(ptr + offset, "%d day%s, ",
days, (days > 1) ? "s" : ""); days, (days > 1) ? "s" : "");
} }
minutes = (int)uptime->uptime / 60; minutes = time / 60;
hours = minutes / 60; hours = minutes / 60;
hours = hours % 24; hours = hours % 24;
minutes = minutes % 60; minutes = minutes % 60;