bughz
/
sigar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix off-by-one bug in proc_args

This commit is contained in:
Doug MacEachern 2004-06-30 21:20:19 +00:00
parent 771742caf9
commit 1c32c2acc9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/os/win32/win32_sigar.c
View File

@ -141,6 +141,7 @@ int sigar_os_open(sigar_t **sigar)
version.dwOSVersionInfoSize = sizeof(version); version.dwOSVersionInfoSize = sizeof(version);
GetVersionEx(&version); GetVersionEx(&version);
(*sigar)->winnt = (*sigar)->winnt =
(version.dwPlatformId == VER_PLATFORM_WIN32_NT); (version.dwPlatformId == VER_PLATFORM_WIN32_NT);
@ -865,6 +866,8 @@ static int sigar_remote_proc_args_get(sigar_t *sigar, sigar_pid_t pid,
return GetLastError(); return GetLastError();
} }
datalen++; /* we want the \0 terminator too */
cmdline = HeapAlloc(GetProcessHeap(), cmdline = HeapAlloc(GetProcessHeap(),
HEAP_ZERO_MEMORY, HEAP_ZERO_MEMORY,
datalen); datalen);
@ -875,7 +878,7 @@ static int sigar_remote_proc_args_get(sigar_t *sigar, sigar_pid_t pid,
} }
if (ReadProcessMemory(proc, data, cmdline, if (ReadProcessMemory(proc, data, cmdline,
datalen+1, &bytes)) datalen, &bytes))
{ {
char *arg, *ptr = cmdline; char *arg, *ptr = cmdline;