Merge 97c561a713 into 6b4b3e0c89

CHANGELOG.md

@@ -22,6 +22,18 @@ Code v99.99.999
 
 ## Unreleased
 
+## [4.93.1](https://github.com/coder/code-server/releases/tag/v4.93.1) - 2024-09-23
+
+Code v1.93.1
+
+### Changed
+
+- Updated to Code 1.93.1.
+
+### Added
+
+- Added `--abs-proxy-base-path` flag for when code-server is not at the root.
+
 ## [4.92.2](https://github.com/coder/code-server/releases/tag/v4.92.2) - 2024-08-19
 
 Code v1.92.2

ci/helm-chart/Chart.yaml

@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 3.23.0
+version: 3.24.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 4.92.2
+appVersion: 4.93.1

ci/helm-chart/values.yaml

@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: codercom/code-server
-  tag: '4.92.2'
+  tag: '4.93.1'
   pullPolicy: Always
 
 # Specifies one or more secrets to be used when pulling images from a

patches/integration.diff

@@ -276,14 +276,12 @@ Index: code-server/lib/vscode/src/server-main.js
 ===================================================================
 --- code-server.orig/lib/vscode/src/server-main.js
 +++ code-server/lib/vscode/src/server-main.js
-@@ -339,4 +339,9 @@ function prompt(question) {
+@@ -339,4 +339,7 @@ function prompt(question) {
  	});
  }
  
 -start();
-+async function loadCodeWithNls() {
++export async function loadCodeWithNls() {
 +	const nlsConfiguration = await resolveNLSConfiguration({ userLocale: 'en', osLocale: 'en', commit: product.commit, userDataPath: '', nlsMetadataPath: __dirname });
 +	return loadCode(nlsConfiguration);
 +}
-+
-+module.exports.loadCodeWithNls = loadCodeWithNls;

src/node/routes/vscode.ts

@@ -41,19 +41,24 @@ export interface IVSCodeServerAPI {
  */
 export type VSCodeModule = {
   // See ../../../lib/vscode/src/server-main.js:339.
-  loadCodeWithNls(): {
+  loadCodeWithNls(): Promise<{
     // See ../../../lib/vscode/src/vs/server/node/server.main.ts:72.
     createServer(address: string | net.AddressInfo | null, args: CodeArgs): Promise<IVSCodeServerAPI>
     // See ../../../lib/vscode/src/vs/server/node/server.main.ts:65.
     spawnCli(args: CodeArgs): Promise<void>
-  }
+  }>
 }
 
 /**
  * Load then create the VS Code server.
  */
 async function loadVSCode(req: express.Request): Promise<IVSCodeServerAPI> {
-  const mod = require(path.join(vsRootPath, "out/server-main")) as VSCodeModule
+  // TypeScript transpiles `import` into `require`, and this is not valid for
+  // ESM, which server-main.js is.  Ideally we convert to ESM, but doing so has
+  // been an endless pit of misery and despair so I am shelving the conversion
+  // and will try again later.  For now, jank it with `eval`.
+  const modulePath = path.join(vsRootPath, "out/server-main.js")
+  const mod = await eval(`import("${modulePath}")`)
   const serverModule = await mod.loadCodeWithNls()
   return serverModule.createServer(null, {
     ...(await toCodeArgs(req.args)),

tsconfig.json

@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
-    "target": "es6",
-    "lib": ["es2020", "dom", "dom.iterable"],
+    "target": "es2022",
+    "lib": ["es2022", "dom", "dom.iterable"],
     "module": "commonjs",
     "moduleResolution": "node",
     "strict": true,