Commit Graph

89 Commits

Author SHA1 Message Date
Asher 3685e6555c
Move and refactor child_process tests 2019-02-19 15:30:56 -06:00
Asher d80f82ab98
Move and refactor fs tests 2019-02-19 14:21:04 -06:00
Asher 2889b3fede
Add test for disposing active evaluations 2019-02-19 10:42:32 -06:00
Asher 4a80bcb42c
Make everything use active evals (#30)
* Add trace log level

* Use active eval to implement spdlog

* Split server/client active eval interfaces

Since all properties are *not* valid on both sides

* +200% fire resistance

* Implement exec using active evaluations

* Fully implement child process streams

* Watch impl, move child_process back to explicitly adding events

Automatically forwarding all events might be the right move, but wanna
think/discuss it a bit more because it didn't come out very cleanly.

* Would you like some args with that callback?

* Implement the rest of child_process using active evals

* Rampant memory leaks

Emit "kill" to active evaluations when client disconnects in order to
kill processes. Most likely won't be the final solution.

* Resolve some minor issues with output panel

* Implement node-pty with active evals

* Provide clearTimeout to vm sandbox

* Implement socket with active evals

* Extract some callback logic

Also remove some eval interfaces, need to re-think those.

* Implement net.Server and remainder of net.Socket using active evals

* Implement dispose for active evaluations

* Use trace for express requests

* Handle sending buffers through evaluation events

* Make event logging a bit more clear

* Fix some errors due to us not actually instantiating until connect/listen

* is this a commit message?

* We can just create the evaluator in the ctor

Not sure what I was thinking.

* memory leak for you, memory leak for everyone

* it's a ternary now

* Don't dispose automatically on close or error

The code may or may not be disposable at that point.

* Handle parsing buffers on the client side as well

* Remove unused protobuf

* Remove TypedValue

* Remove unused forkProvider and test

* Improve dispose pattern for active evals

* Socket calls close after error; no need to bind both

* Improve comment

* Comment is no longer wishy washy due to explicit boolean

* Simplify check for sendHandle and options

* Replace _require with __non_webpack_require__

Webpack will then replace this with `require` which we then provide to
the vm sandbox.

* Provide path.parse

* Prevent original-fs from loading

* Start with a pid of -1

vscode immediately checks the PID to see if the debug process launch
correctly, but of course we don't get the pid synchronously.

* Pass arguments to bootstrap-fork

* Fully implement streams

Was causing errors because internally the stream would set this.writing
to true and it would never become false, so subsequent messages would
never send.

* Fix serializing errors and streams emitting errors multiple times

* Was emitting close to data

* Fix missing path for spawned processes

* Move evaluation onDispose call

Now it's accurate and runs when the active evaluation has actually
disposed.

* Fix promisifying fs.exists

* Fix some active eval callback issues

* Patch existsSync in debug adapter
2019-02-19 10:17:03 -06:00
Asher 73762017c8
Fix failure due to included files when using vscode's log level enum 2019-02-07 14:17:14 -06:00
Asher e4ff8e1c63
Set shared process log level 2019-02-07 13:50:43 -06:00
Asher 86d70ec790
Add constants file 2019-02-07 13:11:01 -06:00
Asher 81f48b8b06
Add trash module 2019-02-07 11:05:17 -06:00
Asher 499798fc17
Wrap shared process in retry 2019-02-06 18:11:31 -06:00
Asher 5d02194048
Throw errors if accessing paths before set 2019-02-06 16:55:29 -06:00
Asher 5ea1d8b2aa
Bit of cleanup, some test fixes, moving some funcs 2019-02-06 16:45:11 -06:00
Asher 66aceb38df
Minimize patched lines 2019-02-06 12:59:03 -06:00
Asher f034aee26e
Remove unused isCi var 2019-02-06 12:05:48 -06:00
Asher 972806b210
Remove no longer used and commented out VSCODE_ALLOW_IO line 2019-02-06 12:02:18 -06:00
Asher 559bdbc147
Mo re spa ci ng 2019-02-06 12:00:51 -06:00
Asher 33b4c96a27
Spa cing 2019-02-06 12:00:01 -06:00
Asher 588da0443c
Some cleanup
- Use whateverEmitter.event for the onWhatever methods.
- Add readonly to a bunch of things.
- Remove some redundancy in types.
- Move initializations out of the constructor and into the declarations
  where it was reasonable to do so.
- Disable a few no-any violations.
2019-02-06 11:53:23 -06:00
Asher ddf96077a3
Pass builtin extension dir to vscode 2019-02-06 11:01:15 -06:00
Asher 91bd6775c3
Move node fill implementations to ide package 2019-02-06 10:49:29 -06:00
Asher 670b13798a
Remove URI factory
It's not actually used anymore.
2019-02-06 10:41:59 -06:00
Asher 1b0a962c0d
Remove loading screen and move require.posix fill 2019-02-06 10:32:58 -06:00
Asher d705bb1180
Rename Client -> IdeClient 2019-02-06 10:18:59 -06:00
Asher 94f977845a
Make event listeners never undefined, remove unused func 2019-02-06 10:16:43 -06:00
Asher e770920be0
Remove block padding (blank lines)
Also made a rule for it.
2019-02-05 18:09:04 -06:00
Asher 70ad911641
vscode-online -> vscode-remote 2019-02-05 15:26:57 -06:00
Kyle Carberry 797efe72fd
Fix loading within the CLI (#27)
* Fix loading within the CLI

* Remove app

* Remove promise handle

* Fix requested changes
2019-02-05 11:16:09 -06:00
Asher c80b2fabc3
Use inline file-loader for require.toUrl
Instead of trying to match on the string, because that string could be
anything or change in future versions.
2019-02-05 11:16:08 -06:00
Asher ec515c0a3f
Skip unsupported actions and menu items
Using this to skip the toggle developer tools action since there doesn't
seem to be any way to do that from the browser. There might be others we
will need to add.
2019-02-05 11:16:07 -06:00
Asher 6bb62005cb
Fix require.toUrl and walkthroughs 2019-02-05 11:16:06 -06:00
Asher a353a59945
Move wheel event change out of patch 2019-02-05 11:16:06 -06:00
Asher b40722869e
Move mouse wheel fix out of patch 2019-02-05 11:16:05 -06:00
Asher d677a2ee37
Fix gutter icons from extensions 2019-02-05 11:16:05 -06:00
Asher e1101c195d
Fix refactoring 2019-02-05 11:16:04 -06:00
Asher c594af4396
More exit debugging
Papers, please.
2019-02-05 11:16:03 -06:00
Asher e585587e67
Fix redundant aliases in command palette 2019-02-05 11:16:03 -06:00
Asher 6c4e2f9251
Terminal pasting 2019-02-05 11:16:03 -06:00
Asher bef46391fa
Enable native clipboard for editor and inputs
StackOverflow will be useful again.
2019-02-05 11:16:02 -06:00
Asher ebe5e1b1a9
Uploader online (#26) 2019-02-05 11:16:02 -06:00
Asher 62b1e0ef00
Surgical removal of a benign TODO 2019-02-05 11:16:02 -06:00
Asher 4a8d11995b
@ts-ignore-be-gone
Spray liberally.
2019-02-05 11:16:01 -06:00
Asher 8fc959e256
There once was an unnecessary ISO date string fill 2019-02-05 11:16:01 -06:00
Asher 8654f9cb06
Fix client not using log dir from shared proc
Needed the path set promise to run first.

And removed the protocol promise stuff that was hanging around not doing
anything useful.
2019-02-05 11:16:00 -06:00
Asher a0c443d8d3
Sometimes an exec has no callback
How lonely.
2019-02-05 11:16:00 -06:00
Kyle Carberry 20f5d8eeed
Add active evals (#25)
* Add active evals

* Convert type of stats to date or string

* Fix generic overloads for run

* Lower evaluate timeout

* Add comment for createWriteStream
2019-02-05 11:16:00 -06:00
Asher 3a88ae5fb2
Get search working and clean up disconnected client (#23)
* Use ipc instead of pipe

* Run callback passed to child process's send method

* It also returns true

* Correct send signature

* Kill processes when client disconnects
2019-02-05 11:15:59 -06:00
Kyle Carberry b4798d1a48
Fix syntax highlighting, process spawning, extensions, terminals (#22)
* Fix syntax highlighting, process spawning, extensions, terminals

* Replace colons in toISOString

* Move pathSets included in task
2019-02-05 11:15:59 -06:00
Kyle Carberry 9b1a635d63
Add static file serve for resources inside of data-directory (#19) 2019-02-05 11:15:59 -06:00
Asher c6d35d098a
Extension host (#20)
* Implement net.Server

* Move Socket class into Client

This way we don't need to expose anything.

* Remove some unused imports

* Pass environment variables to bootstrap fork

* Add debug log for when socket disconnects from server

* Use VSCODE_ALLOW_IO for shared process only

* Extension host can send messages now

* Support callback for logging

This lets us do potentially expensive operations which will only be
performed if the log level is sufficiently low.

* Stop extension host from committing suicide

* Blank line

* Add static serve (#21)

* Add extension URLs

* how did i remove this

* Fix writing an empty string

* Implement dialogs on window service
2019-02-05 11:15:58 -06:00
Asher 536ded2cc5
Add some debug logging 2019-02-05 11:15:58 -06:00
Asher b08237d63f
Fill net.createServer 2019-02-05 11:15:57 -06:00