bughz
/
code-server
mirror of https://github.com/coder/code-server.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

docs(patches): update testing info for node-version

This commit is contained in:
Joe Previte 2022-04-28 09:51:51 -07:00
parent 013934dcb5
commit b6a3f9a533
No known key found for this signature in database
GPG Key ID: 2C91590C6B742C24
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
patches/node-version.diff
View File

@ -4,8 +4,12 @@ Previously it would use the yarnrc which results in builds that cannot run with
the version of Node they were built with because the native modules are the version of Node they were built with because the native modules are
targeting the wrong version. targeting the wrong version.
One way test this is to build in a fresh Docker container, run the build, then To test this:
try opening the built-in terminal.
1. build fresh Coder workspace
2. clone code-server
3. `yarn watch`
4. test built-in terminal
Index: code-server/lib/vscode/build/gulpfile.reh.js Index: code-server/lib/vscode/build/gulpfile.reh.js
=================================================================== ===================================================================