fix: minor fixes related to release (#5732)

* fix: use * for test plugin engines

This removes the need to update this version with every version change.

* refactor: use npm-package in release assets

This adds a new job to `release.yaml` to upload the `npm-package` to the
release assets which will also allow us to download it in the
`publish.yaml` workflow.

* docs: update release instructions

* fixup!: use package.tar.gz

.github/workflows/publish.yaml

@@ -28,15 +28,13 @@ jobs:
         id: version
         run: echo "::set-output name=version::$(jq -r .version package.json)"
 
-      - name: Download artifact
+      - name: Download npm package from release artifacts
-        uses: dawidd6/action-download-artifact@v2
+        uses: robinraju/release-downloader@v1.5
-        id: download
         with:
-          branch: release/v${{ steps.version.outputs.version }}
+          repository: "coder/code-server"
-          workflow: build.yaml
+          tag: v${{ steps.version.outputs.version }}
-          workflow_conclusion: completed
+          fileName: "package.tar.gz"
-          name: "npm-package"
+          out-file-path: "release-npm-package"
-          path: release-npm-package
 
       - name: Publish npm package and tag with "latest"
         run: yarn publish:npm

.github/workflows/release.yaml

@@ -249,3 +249,24 @@ jobs:
           draft: true
           discussion_category_name: "📣 Announcements"
           files: ./release-packages/*
+
+  npm-package:
+    name: Upload npm package
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - name: Download artifacts
+        uses: dawidd6/action-download-artifact@v2
+        id: download
+        with:
+          branch: ${{ github.ref }}
+          workflow: build.yaml
+          workflow_conclusion: completed
+          check_artifacts: true
+          name: npm-package
+
+      - uses: softprops/action-gh-release@v1
+        with:
+          draft: true
+          discussion_category_name: "📣 Announcements"
+          files: ./package.tar.gz

docs/MAINTAINING.md

@@ -141,8 +141,7 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS).
 
 ### Publishing a release
 
-1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0)
+1. Create a new branch called `release`
-   1. If you don't do this, the `npm-brew` GitHub workflow will fail. It looks for the release artifacts under the branch pattern.
 1. Run `yarn release:prep`
 1. Bump chart version in `Chart.yaml`.
 1. Summarize the major changes in the `CHANGELOG.md`

test/unit/node/test-plugin/package.json

@@ -3,7 +3,7 @@
   "name": "test-plugin",
   "version": "1.0.0",
   "engines": {
-    "code-server": "^4.8.1"
+    "code-server": "*"
   },
   "main": "out/index.js",
   "devDependencies": {