bughz
/
code-server
mirror of https://github.com/coder/code-server.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: add helpAbout test instead of goHome

This commit is contained in:
Joe Previte 2021-03-16 14:19:36 -07:00
parent bcdca86539
commit 3d9d2e592d
No known key found for this signature in database
GPG Key ID: 2C91590C6B742C24
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/helpAbout.test.ts
View File

@ -9,7 +9,7 @@ describe("Open Help > About", () => {
let context: BrowserContext let context: BrowserContext
beforeAll(async () => { beforeAll(async () => {
browser = await chromium.launch({ headless: false }) browser = await chromium.launch()
// Create a new context with the saved storage state // Create a new context with the saved storage state
const storageState = JSON.parse(STORAGE) || {} const storageState = JSON.parse(STORAGE) || {}
@ -62,11 +62,6 @@ describe("Open Help > About", () => {
}) })
it("should see a 'Help' then 'About' button in the Application Menu that opens a dialog", async () => { it("should see a 'Help' then 'About' button in the Application Menu that opens a dialog", async () => {
// Sometimes a dialog shows up when you navigate
// asking if you're sure you want to leave
// so we listen if it comes, we accept it
// page.on("dialog", (dialog) => dialog.accept())
// waitUntil: "domcontentloaded" // waitUntil: "domcontentloaded"
// In case the page takes a long time to load // In case the page takes a long time to load
await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "domcontentloaded" }) await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "domcontentloaded" })
@ -80,13 +75,17 @@ describe("Open Help > About", () => {
const helpButton = "a.action-menu-item span[aria-label='Help']" const helpButton = "a.action-menu-item span[aria-label='Help']"
expect(await page.isVisible(helpButton)) expect(await page.isVisible(helpButton))
// Click it and navigate to /healthz // Hover the helpButton
// NOTE: ran into issues of it failing intermittently await page.hover(helpButton)
// without having button: "middle"
await Promise.all([page.waitForNavigation(), page.click(helpButton, { button: "middle" })])
// see the About button // see the About button and click it
const aboutButton = "a.action-menu-item span[aria-label='About']" const aboutButton = "a.action-menu-item span[aria-label='About']"
expect(await page.isVisible(aboutButton)) expect(await page.isVisible(aboutButton))
// NOTE: it won't work unless you hover it first
await page.hover(aboutButton)
await page.click(aboutButton)
const codeServerText = "text=code-server"
expect(await page.isVisible(codeServerText))
}) })
}) })