Compare commits

..

No commits in common. "main" and "v0.0.16" have entirely different histories.

9 changed files with 18 additions and 123 deletions

View File

@ -2,11 +2,8 @@ package bgptools
import (
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
)
@ -17,53 +14,6 @@ func (fn privacyRoundTripper) RoundTrip(request *http.Request) (*http.Response,
return fn(request)
}
func TestStructuredReportErrorsDoNotExposeRemoteURLs(t *testing.T) {
var rdap *httptest.Server
rdap = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
_, _ = fmt.Fprintf(w, `{"handle":"TEST","links":[{"rel":"geofeed","href":"https://private.example/geofeed?token=secret"}]}`)
}))
defer rdap.Close()
failing := &http.Client{Transport: privacyRoundTripper(func(request *http.Request) (*http.Response, error) {
return nil, errors.New("dial " + request.URL.String())
})}
report, err := QueryIPBGPReport(context.Background(), "192.0.2.1", IPBGPReportConfig{
RDAPClient: rdap.Client(),
RDAPBaseURL: rdap.URL,
FetchGeofeed: true,
GeofeedClient: failing,
ResolveASN: func(context.Context, string) (string, error) {
return "", errors.New("resolver https://private.example/asn?key=secret")
},
})
if err != nil {
t.Fatal(err)
}
for _, source := range report.Sources {
for _, field := range []string{source.Source, source.Error} {
for _, forbidden := range []string{"private.example", "token=", "key=", "secret"} {
if strings.Contains(field, forbidden) {
t.Fatalf("structured source leaked %q: %+v", forbidden, source)
}
}
}
}
if len(report.Geofeeds) != 1 || report.Geofeeds[0].Error != "request_failed" {
t.Fatalf("geofeed error was not stabilized: %+v", report.Geofeeds)
}
encoded, err := json.Marshal(report)
if err != nil {
t.Fatal(err)
}
for _, forbidden := range []string{"token=", "key=", "secret", "userinfo@"} {
if strings.Contains(string(encoded), forbidden) {
t.Fatalf("structured report leaked %q: %s", forbidden, encoded)
}
}
if report.RDAP == nil || len(report.RDAP.GeofeedURLs) != 1 || report.RDAP.GeofeedURLs[0] != "https://private.example/geofeed" || report.Geofeeds[0].URL != "https://private.example/geofeed" {
t.Fatalf("geofeed URL was not sanitized consistently: %+v", report)
}
}
func TestRemoteFetchErrorsDoNotExposeSourceURL(t *testing.T) {
client := &http.Client{Transport: privacyRoundTripper(func(request *http.Request) (*http.Response, error) {
return nil, errors.New("dial " + request.URL.String())

View File

@ -128,7 +128,7 @@ func parseRDAPRecord(ip, source string, data []byte) (RDAPRecord, error) {
record := RDAPRecord{
IP: ip, Handle: payload.Handle, Name: payload.Name, Type: payload.Type,
Country: payload.Country, StartAddress: payload.StartAddress, EndAddress: payload.EndAddress,
ParentHandle: payload.ParentHandle, Port43: payload.Port43, Status: payload.Status, Source: "rdap",
ParentHandle: payload.ParentHandle, Port43: payload.Port43, Status: payload.Status, Source: source,
}
for _, event := range payload.Events {
switch strings.ToLower(event.Action) {

View File

@ -131,7 +131,7 @@ func QueryASNRelationships(ctx context.Context, asn string, cfg RelationshipConf
report := &ASNRelationshipReport{TargetASN: normalized}
ripeURL, err := addQuery(cfg.RIPEstatURL, "resource", normalized)
if err != nil {
return nil, errors.New("invalid relationship source configuration")
return nil, err
}
ripeRaw, ripeStatus, ripeErr := fetchRelationshipJSON(ctx, cfg, "ripestat", ripeURL)
report.SourceStatuses = append(report.SourceStatuses, sourceStatus("ripestat", ripeStatus, ripeErr))
@ -153,7 +153,7 @@ func QueryASNRelationships(ctx context.Context, asn string, cfg RelationshipConf
peeringURL, err := addQuery(cfg.PeeringDBURL, "asn", normalized)
if err != nil {
return nil, errors.New("invalid relationship source configuration")
return nil, err
}
peeringRaw, peeringStatus, peeringErr := fetchRelationshipJSON(ctx, cfg, "peeringdb", peeringURL)
report.SourceStatuses = append(report.SourceStatuses, sourceStatus("peeringdb", peeringStatus, peeringErr))
@ -255,16 +255,7 @@ func sourceStatus(source string, status RelationshipStatus, err error) Relations
Timeout: status == RelationshipTimeout,
}
if err != nil {
switch status {
case RelationshipRateLimited:
item.Error = "rate_limited"
case RelationshipTimeout:
item.Error = "timeout"
case RelationshipMissingFields:
item.Error = "missing_fields"
default:
item.Error = "request_failed"
}
item.Error = err.Error()
}
return item
}

View File

@ -217,12 +217,6 @@ func QueryIPBGPReport(parent context.Context, ip string, cfg IPBGPReportConfig)
geofeedURLs = append(geofeedURLs, report.WHOIS.GeofeedURLs...)
}
geofeedURLs = uniqueSortedStrings(geofeedURLs)
if report.RDAP != nil {
report.RDAP.GeofeedURLs = sanitizeReportURLs(report.RDAP.GeofeedURLs)
}
if report.WHOIS != nil {
report.WHOIS.GeofeedURLs = sanitizeReportURLs(report.WHOIS.GeofeedURLs)
}
for _, geofeedURL := range geofeedURLs {
if !cfg.FetchGeofeed {
report.Geofeeds = append(report.Geofeeds, GeofeedResult{URL: geofeedURL, Status: ReportUnsupported, Error: "fetch disabled"})
@ -230,7 +224,7 @@ func QueryIPBGPReport(parent context.Context, ip string, cfg IPBGPReportConfig)
}
result := fetchGeofeed(ctx, geofeedURL, cfg)
report.Geofeeds = append(report.Geofeeds, result)
report.Sources = append(report.Sources, IPBGPSourceStatus{Source: "geofeed", Status: result.Status, Error: result.Error})
report.Sources = append(report.Sources, IPBGPSourceStatus{Source: "geofeed:" + geofeedURL, Status: result.Status, Error: result.Error})
}
asn := strings.TrimSpace(cfg.ASN)
@ -292,7 +286,7 @@ func inferRIR(record RDAPRecord, available bool) RIRInfo {
}
func fetchGeofeed(parent context.Context, rawURL string, cfg IPBGPReportConfig) GeofeedResult {
result := GeofeedResult{URL: sanitizeReportURL(rawURL)}
result := GeofeedResult{URL: rawURL}
u, err := url.Parse(rawURL)
if err != nil || u.Host == "" || (u.Scheme != "http" && u.Scheme != "https") {
result.Status = ReportUnsupported
@ -316,7 +310,7 @@ func fetchGeofeed(parent context.Context, rawURL string, cfg IPBGPReportConfig)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
if err != nil {
result.Status = ReportError
result.Error = stableReportError(result.Status, err)
result.Error = err.Error()
return result
}
req.Header.Set("Accept", "text/csv, text/plain, */*")
@ -324,7 +318,7 @@ func fetchGeofeed(parent context.Context, rawURL string, cfg IPBGPReportConfig)
resp, err := client.Do(req)
if err != nil {
result.Status = reportStatusForError(err)
result.Error = stableReportError(result.Status, err)
result.Error = err.Error()
return result
}
defer resp.Body.Close()
@ -347,7 +341,7 @@ func fetchGeofeed(parent context.Context, rawURL string, cfg IPBGPReportConfig)
body, err := io.ReadAll(io.LimitReader(resp.Body, maxBytes+1))
if err != nil {
result.Status = reportStatusForError(err)
result.Error = stableReportError(result.Status, err)
result.Error = err.Error()
return result
}
if int64(len(body)) > maxBytes {
@ -523,51 +517,11 @@ func rirNameFromText(value string) string {
func sourceStatusForError(source string, status ReportStatus, err error) IPBGPSourceStatus {
item := IPBGPSourceStatus{Source: source, Status: status}
if err != nil {
item.Error = stableReportError(status, err)
item.Error = err.Error()
}
return item
}
func stableReportError(status ReportStatus, err error) string {
if errors.Is(err, context.Canceled) {
return "canceled"
}
switch status {
case ReportRateLimited:
return "rate_limited"
case ReportTimeout:
return "timeout"
case ReportUnsupported:
return "unsupported"
case ReportMissingFields:
return "missing_fields"
default:
return "request_failed"
}
}
func sanitizeReportURL(raw string) string {
parsed, err := url.Parse(strings.TrimSpace(raw))
if err != nil || parsed.Host == "" || (parsed.Scheme != "http" && parsed.Scheme != "https") {
return ""
}
parsed.User = nil
parsed.RawQuery = ""
parsed.ForceQuery = false
parsed.Fragment = ""
return parsed.String()
}
func sanitizeReportURLs(values []string) []string {
result := make([]string, 0, len(values))
for _, value := range values {
if sanitized := sanitizeReportURL(value); sanitized != "" {
result = append(result, sanitized)
}
}
return uniqueSortedStrings(result)
}
func reportStatusForError(err error) ReportStatus {
if err == nil {
return ReportAvailable

View File

@ -210,7 +210,6 @@
240e:4b:8000::/33
240e:4b::/33
240e:4c:4006::/48
240e:4c:5000::/48
240e:4c:8000::/33
240e:4c::/33
240e:4d:50ff::/48

View File

@ -1,7 +1,7 @@
{
"schema": "backtrace.asn-prefixes/v1",
"file": "as4134.txt",
"count": 629,
"sha256": "00941f76c022566166b926670ee9358084c53465cbaaf75a3da7b73d997d1947",
"generated_at": "2026-07-23T02:56:31Z"
"count": 628,
"sha256": "9e032d30479db6c5bd167681048922765c23d1a35b01ed9e6968b2099b8b916f",
"generated_at": "2026-07-20T19:12:53Z"
}

View File

@ -6639,6 +6639,7 @@
2409:8c7c::/32
2409:8c7e:9301::/48
2409:8c7e::/32
2409:8c85:1000::/48
2409:8c85:1001::/48
2409:8c85:1::/48
2409:8c85:200::/48

View File

@ -1,7 +1,7 @@
{
"schema": "backtrace.asn-prefixes/v1",
"file": "as9808.txt",
"count": 7170,
"sha256": "7532e5bba93ed6b7d5cf010b22d9f5c87606392673fd9877ce28417f2baadd5d",
"generated_at": "2026-07-23T02:56:31Z"
"count": 7171,
"sha256": "c362e447b515ca510b10fd37ba50189c3551a35dede88399190bc869b6fbe66b",
"generated_at": "2026-07-20T19:12:54Z"
}

View File

@ -2,7 +2,7 @@ package model
import "time"
const BackTraceVersion = "v0.0.17"
const BackTraceVersion = "v0.0.16"
var EnableLoger = false