From 7a3fd81a8d3ce30ad8309b5897facde461e1f535 Mon Sep 17 00:00:00 2001 From: rofl0r Date: Mon, 27 Nov 2017 19:12:12 +0000 Subject: [PATCH] fix types used in SOCKS4/5 support code the line len = buff[0]; /* max = 255 */ could lead to a negative length if the value in buff[0] is > 127. --- src/reqs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/reqs.c b/src/reqs.c index a3d8162..86039bc 100644 --- a/src/reqs.c +++ b/src/reqs.c @@ -1270,8 +1270,8 @@ static void relay_connection (struct conn_s *connptr) static int connect_to_upstream_proxy(struct conn_s *connptr, struct request_s *request) { - int len; - char buff[512]; /* won't use more than 7 + 255 */ + unsigned len; + unsigned char buff[512]; /* won't use more than 7 + 255 */ unsigned short port; struct hostent *host; struct upstream *cur_upstream = connptr->upstream_proxy;