bughz
/
code-server
mirror of https://github.com/coder/code-server.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Filter blank plugin directories (#2187) 

I neglected to realize that "".split(":") is an array with "" in it.
This commit is contained in:
Asher 2020-10-11 01:14:43 -05:00 committed by GitHub
parent 811cf3364a
commit c6ba12942c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/node/plugin.ts
View File

@ -75,12 +75,18 @@ export const loadPlugins = async (httpServer: HttpServer, args: Args): Promise<v
// Built-in plugins. // Built-in plugins.
_loadPlugins(path.resolve(__dirname, "../../plugins"), httpServer, args), _loadPlugins(path.resolve(__dirname, "../../plugins"), httpServer, args),
// User-added plugins. // User-added plugins.
...pluginPath.split(":").map((dir) => _loadPlugins(path.resolve(dir), httpServer, args)), ...pluginPath
.split(":")
.filter((p) => !!p)
.map((dir) => _loadPlugins(path.resolve(dir), httpServer, args)),
// Individual plugins so you don't have to symlink or move them into a // Individual plugins so you don't have to symlink or move them into a
// directory specifically for plugins. This lets you load plugins that are // directory specifically for plugins. This lets you load plugins that are
// on the same level as other directories that are not plugins (if you tried // on the same level as other directories that are not plugins (if you tried
// to use CS_PLUGIN_PATH code-server would try to load those other // to use CS_PLUGIN_PATH code-server would try to load those other
// directories as plugins). Intended for development. // directories as plugins). Intended for development.
...plugin.split(":").map((dir) => loadPlugin(path.resolve(dir), httpServer, args)), ...plugin
.split(":")
.filter((p) => !!p)
.map((dir) => loadPlugin(path.resolve(dir), httpServer, args)),
]) ])
} }