From a0944006e793b6aaf6a84ec859cfb4a244cdd831 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Sat, 17 Sep 2022 10:20:28 -0700 Subject: [PATCH] refactor: delete buggy socket test This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions --- test/unit/node/app.test.ts | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/unit/node/app.test.ts b/test/unit/node/app.test.ts index a6c9c0f27..36c004e46 100644 --- a/test/unit/node/app.test.ts +++ b/test/unit/node/app.test.ts @@ -107,20 +107,6 @@ describe("createApp", () => { app.dispose() }) - // TODO@jsjoeio - delete because this test it buggy? - // or move into it's own describe block - it("should change the file mode of a socket", async () => { - const defaultArgs = await setDefaults({ - socket: tmpFilePath, - "socket-mode": "777", - }) - - const app = await createApp(defaultArgs) - - expect((await promises.stat(tmpFilePath)).mode & 0o777).toBe(0o777) - app.dispose() - }) - it("should create an https server if args.cert exists", async () => { const testCertificate = await generateCertificate("localhost") const cert = new OptionalString(testCertificate.cert)