From bb5c7d95ccf5f4f70de07d20e54320302fbe6ee4 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 25 Mar 2021 15:06:34 -0700 Subject: [PATCH 1/2] chore: fix release_template todos --- .github/PULL_REQUEST_TEMPLATE/release_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/release_template.md b/.github/PULL_REQUEST_TEMPLATE/release_template.md index 028b9753b..c97f47eb0 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/release_template.md @@ -10,7 +10,8 @@ TODO - [ ] test locally - [ ] upload assets to draft release -- [ ] double-check github release tag is the commit with artifacts +- [ ] test one of the release packages locally +- [ ] double-check github release tag is the commit with artifacts (*note gets messed up after uploading assets*) - [ ] publish release - [ ] merge PR - [ ] update the homebrew package From 024a3110beb01f89e9e835cac45057b8bc9b0b6a Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 25 Mar 2021 15:06:56 -0700 Subject: [PATCH 2/2] refactor: reorganize release notes draft format --- .../PULL_REQUEST_TEMPLATE/release_template.md | 2 +- ci/build/release-github-draft.sh | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/release_template.md b/.github/PULL_REQUEST_TEMPLATE/release_template.md index c97f47eb0..a88b6de17 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/release_template.md @@ -11,7 +11,7 @@ TODO - [ ] test locally - [ ] upload assets to draft release - [ ] test one of the release packages locally -- [ ] double-check github release tag is the commit with artifacts (*note gets messed up after uploading assets*) +- [ ] double-check github release tag is the commit with artifacts (_note gets messed up after uploading assets_) - [ ] publish release - [ ] merge PR - [ ] update the homebrew package diff --git a/ci/build/release-github-draft.sh b/ci/build/release-github-draft.sh index fb4e9720e..d9facac5e 100755 --- a/ci/build/release-github-draft.sh +++ b/ci/build/release-github-draft.sh @@ -21,20 +21,27 @@ installations. ## New Features - - ⭐ Summarize new features here with references to issues +⭐ Summarize new features here with references to issues -## VS Code - - ⭐ Summarize VS Code version update here with references to issues + - item ## Bug Fixes - - ⭐ Summarize bug fixes here with references to issues + +⭐ Summarize bug fixes here with references to issues + + - item ## Documentation - - ⭐ Summarize doc changes here with references to issues + +⭐ Summarize doc changes here with references to issues + + - item ## Development - - ⭐ Summarize development/testing changes here with references to issues +⭐ Summarize development/testing changes here with references to issues + + - item Cheers! 🍻 EOF