From 546dd9c278ae2dbebd5dd3c3df1a03fd836682ed Mon Sep 17 00:00:00 2001 From: Asher Date: Tue, 1 Jun 2021 16:04:26 -0500 Subject: [PATCH] Catch getLayoutMap error (#3518) This might be causing issues with the PWA showing a blank screen with MacOS. --- .../services/keybinding/browser/keyboardLayoutService.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/vscode/src/vs/workbench/services/keybinding/browser/keyboardLayoutService.ts b/lib/vscode/src/vs/workbench/services/keybinding/browser/keyboardLayoutService.ts index 6d71a818b..0fcefe306 100644 --- a/lib/vscode/src/vs/workbench/services/keybinding/browser/keyboardLayoutService.ts +++ b/lib/vscode/src/vs/workbench/services/keybinding/browser/keyboardLayoutService.ts @@ -406,6 +406,9 @@ export class BrowserKeyboardMapperFactoryBase { // } // return null; + }).catch(() => { + // NOTE@coder: It looks like the intention was to catch this error but + // a try/catch won't do it when using promises without `await`. }); } catch { // getLayoutMap can throw if invoked from a nested browsing context