From 2bf0a0e76ed5a3d1ff0a464cad2696f51d147acd Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 20 Apr 2021 10:48:17 -0700 Subject: [PATCH] refactor: fix tests to check visibility correctly --- test/e2e/globalSetup.test.ts | 2 +- test/e2e/login.test.ts | 2 +- test/e2e/logout.test.ts | 4 ++-- test/e2e/openHelpAbout.test.ts | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/e2e/globalSetup.test.ts b/test/e2e/globalSetup.test.ts index d0eb8ccc7..28d89bfc3 100644 --- a/test/e2e/globalSetup.test.ts +++ b/test/e2e/globalSetup.test.ts @@ -20,6 +20,6 @@ test.describe("globalSetup", () => { test("should keep us logged in using the storageState", options, async ({ page }) => { await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "networkidle" }) // Make sure the editor actually loaded - expect(await page.isVisible("div.monaco-workbench")) + expect(await page.isVisible("div.monaco-workbench")).toBe(true) }) }) diff --git a/test/e2e/login.test.ts b/test/e2e/login.test.ts index 4277e2cd3..e74c81c8d 100644 --- a/test/e2e/login.test.ts +++ b/test/e2e/login.test.ts @@ -24,7 +24,7 @@ test.describe("login", () => { await page.click(".submit") await page.waitForLoadState("networkidle") // Make sure the editor actually loaded - expect(await page.isVisible("div.monaco-workbench")) + expect(await page.isVisible("div.monaco-workbench")).toBe(true) }) test("should see an error message for missing password", options, async ({ page }) => { diff --git a/test/e2e/logout.test.ts b/test/e2e/logout.test.ts index e3ef887a5..aa080f5f1 100644 --- a/test/e2e/logout.test.ts +++ b/test/e2e/logout.test.ts @@ -17,14 +17,14 @@ test.describe("logout", () => { await page.click(".submit") await page.waitForLoadState("networkidle") // Make sure the editor actually loaded - expect(await page.isVisible("div.monaco-workbench")) + expect(await page.isVisible("div.monaco-workbench")).toBe(true) // Click the Application menu await page.click("[aria-label='Application Menu']") // See the Log out button const logoutButton = "a.action-menu-item span[aria-label='Log out']" - expect(await page.isVisible(logoutButton)) + expect(await page.isVisible(logoutButton)).toBe(true) await page.hover(logoutButton) // TODO(@jsjoeio) diff --git a/test/e2e/openHelpAbout.test.ts b/test/e2e/openHelpAbout.test.ts index c1070824f..9de696955 100644 --- a/test/e2e/openHelpAbout.test.ts +++ b/test/e2e/openHelpAbout.test.ts @@ -21,26 +21,26 @@ test.describe("Open Help > About", () => { async ({ page }) => { await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "networkidle" }) // Make sure the editor actually loaded - expect(await page.isVisible("div.monaco-workbench")) + expect(await page.isVisible("div.monaco-workbench")).toBe(true) // Click the Application menu await page.click("[aria-label='Application Menu']") // See the Help button const helpButton = "a.action-menu-item span[aria-label='Help']" - expect(await page.isVisible(helpButton)) + expect(await page.isVisible(helpButton)).toBe(true) // Hover the helpButton await page.hover(helpButton) // see the About button and click it const aboutButton = "a.action-menu-item span[aria-label='About']" - expect(await page.isVisible(aboutButton)) + expect(await page.isVisible(aboutButton)).toBe(true) // NOTE: it won't work unless you hover it first await page.hover(aboutButton) await page.click(aboutButton) const codeServerText = "text=code-server" - expect(await page.isVisible(codeServerText)) + expect(await page.isVisible(codeServerText)).toBe(true) }, ) })