From 11b2ef9846e834cbe54e78a68e7ddb5350581e65 Mon Sep 17 00:00:00 2001
From: Joe Previte <jjprevite@gmail.com>
Date: Tue, 9 Aug 2022 15:41:37 -0500
Subject: [PATCH] feat: add test for EXTENSIONS_GALLERY (#5432)

* refactor: add env arg to runCodeServerCommand

This allows yous to pass environment variables to code-server's helper
when running integration tests.

* feat: add EXTENSIONS_GALLERY integration test

This test ensures EXTENSIONS_GALLERY is read when set and using the
`--install-extension` flag.

Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
---
 test/integration/installExtension.test.ts | 7 +++++++
 test/utils/runCodeServerCommand.ts        | 9 +++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/test/integration/installExtension.test.ts b/test/integration/installExtension.test.ts
index d22cee802..ad4756f8a 100644
--- a/test/integration/installExtension.test.ts
+++ b/test/integration/installExtension.test.ts
@@ -22,4 +22,11 @@ describe("--install-extension", () => {
     const statInfo = await stat(pathToExtFolder)
     expect(statInfo.isDirectory()).toBe(true)
   }, 20000)
+  it("should use EXTENSIONS_GALLERY when set", async () => {
+    const extName = `author.extension-1.0.0`
+    const { stderr } = await runCodeServerCommand([...setupFlags, "--install-extension", extName], {
+      EXTENSIONS_GALLERY: "{}",
+    })
+    expect(stderr).toMatch("No extension gallery service configured")
+  })
 })
diff --git a/test/utils/runCodeServerCommand.ts b/test/utils/runCodeServerCommand.ts
index cb1e45638..bd526e85a 100644
--- a/test/utils/runCodeServerCommand.ts
+++ b/test/utils/runCodeServerCommand.ts
@@ -6,9 +6,14 @@ import { promisify } from "util"
  *
  * A helper function for integration tests to run code-server commands.
  */
-export async function runCodeServerCommand(argv: string[]): Promise<{ stdout: string; stderr: string }> {
+export async function runCodeServerCommand(
+  argv: string[],
+  env?: NodeJS.ProcessEnv,
+): Promise<{ stdout: string; stderr: string }> {
   const CODE_SERVER_COMMAND = process.env.CODE_SERVER_PATH || path.resolve("../../release-standalone/bin/code-server")
-  const { stdout, stderr } = await promisify(exec)(`${CODE_SERVER_COMMAND} ${argv.join(" ")}`)
+  const { stdout, stderr } = await promisify(exec)(`${CODE_SERVER_COMMAND} ${argv.join(" ")}`, {
+    env: { ...process.env, ...env },
+  })
 
   return { stdout, stderr }
 }