From 0c2708302d1587196192c31cae470e26683e1563 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 16 Mar 2021 12:18:33 -0700 Subject: [PATCH] refactor: remove --home flag/feature We are removing this because it was removed upstream in PR~115599. --- .github/workflows/ci.yaml | 2 +- ci/dev/test.sh | 3 -- docs/FAQ.md | 70 +++++++++++++++++---------------------- src/node/cli.ts | 5 --- test/cli.test.ts | 2 -- 5 files changed, 31 insertions(+), 51 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index de514b573..9c2cc2bdf 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -40,7 +40,7 @@ jobs: - uses: microsoft/playwright-github-action@v1 - name: Install dependencies and run tests run: | - ./release-packages/code-server*-linux-amd64/bin/code-server --home $CODE_SERVER_ADDRESS/healthz & + ./release-packages/code-server*-linux-amd64/bin/code-server & yarn --frozen-lockfile yarn test - name: Upload test artifacts diff --git a/ci/dev/test.sh b/ci/dev/test.sh index 82f6ad361..23e1ed7b9 100755 --- a/ci/dev/test.sh +++ b/ci/dev/test.sh @@ -16,9 +16,6 @@ main() { echo " \$PASSWORD" echo " \$CODE_SERVER_ADDRESS" echo -e "\n" - echo "Please make sure you have code-server running locally with the flag:" - echo " --home \$CODE_SERVER_ADDRESS/healthz " - echo -e "\n" exit 1 fi CS_DISABLE_PLUGINS=true ./test/node_modules/.bin/jest "$@" diff --git a/docs/FAQ.md b/docs/FAQ.md index 9b08b58d3..779bd83d9 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -2,36 +2,36 @@ # FAQ -- [Questions?](#questions) -- [iPad Status?](#ipad-status) -- [Community Projects (awesome-code-server)](#community-projects-awesome-code-server) -- [How can I reuse my VS Code configuration?](#how-can-i-reuse-my-vs-code-configuration) -- [Differences compared to VS Code?](#differences-compared-to-vs-code) -- [How can I request a missing extension?](#how-can-i-request-a-missing-extension) -- [How do I configure the marketplace URL?](#how-do-i-configure-the-marketplace-url) -- [Where are extensions stored?](#where-are-extensions-stored) -- [How is this different from VS Code Codespaces?](#how-is-this-different-from-vs-code-codespaces) -- [How should I expose code-server to the internet?](#how-should-i-expose-code-server-to-the-internet) -- [Can I store my password hashed?](#can-i-store-my-password-hashed) -- [How do I securely access web services?](#how-do-i-securely-access-web-services) - - [Sub-paths](#sub-paths) - - [Sub-domains](#sub-domains) -- [Why does the code-server proxy strip `/proxy/` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path) - - [Proxying to Create React App](#proxying-to-create-react-app) -- [Multi-tenancy](#multi-tenancy) -- [Docker in code-server container?](#docker-in-code-server-container) -- [How can I disable telemetry?](#how-can-i-disable-telemetry) -- [How does code-server decide what workspace or folder to open?](#how-does-code-server-decide-what-workspace-or-folder-to-open) -- [How do I debug issues with code-server?](#how-do-i-debug-issues-with-code-server) -- [Heartbeat File](#heartbeat-file) -- [Healthz endpoint](#healthz-endpoint) -- [How does the config file work?](#how-does-the-config-file-work) -- [How do I customize the "Go Home" button?](#how-do-i-customize-the-go-home-button) -- [Isn't an install script piped into sh insecure?](#isnt-an-install-script-piped-into-sh-insecure) -- [How do I make my keyboard shortcuts work?](#how-do-i-make-my-keyboard-shortcuts-work) -- [Differences compared to Theia?](#differences-compared-to-theia) -- [`$HTTP_PROXY`, `$HTTPS_PROXY`, `$NO_PROXY`](#http_proxy-https_proxy-no_proxy) -- [Enterprise](#enterprise) +- [FAQ](#faq) + - [Questions?](#questions) + - [iPad Status?](#ipad-status) + - [Community Projects (awesome-code-server)](#community-projects-awesome-code-server) + - [How can I reuse my VS Code configuration?](#how-can-i-reuse-my-vs-code-configuration) + - [Differences compared to VS Code?](#differences-compared-to-vs-code) + - [How can I request a missing extension?](#how-can-i-request-a-missing-extension) + - [How do I configure the marketplace URL?](#how-do-i-configure-the-marketplace-url) + - [Where are extensions stored?](#where-are-extensions-stored) + - [How is this different from VS Code Codespaces?](#how-is-this-different-from-vs-code-codespaces) + - [How should I expose code-server to the internet?](#how-should-i-expose-code-server-to-the-internet) + - [Can I store my password hashed?](#can-i-store-my-password-hashed) + - [How do I securely access web services?](#how-do-i-securely-access-web-services) + - [Sub-paths](#sub-paths) + - [Sub-domains](#sub-domains) + - [Why does the code-server proxy strip `/proxy/` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path) + - [Proxying to Create React App](#proxying-to-create-react-app) + - [Multi-tenancy](#multi-tenancy) + - [Docker in code-server container?](#docker-in-code-server-container) + - [How can I disable telemetry?](#how-can-i-disable-telemetry) + - [How does code-server decide what workspace or folder to open?](#how-does-code-server-decide-what-workspace-or-folder-to-open) + - [How do I debug issues with code-server?](#how-do-i-debug-issues-with-code-server) + - [Heartbeat File](#heartbeat-file) + - [Healthz endpoint](#healthz-endpoint) + - [How does the config file work?](#how-does-the-config-file-work) + - [Isn't an install script piped into sh insecure?](#isnt-an-install-script-piped-into-sh-insecure) + - [How do I make my keyboard shortcuts work?](#how-do-i-make-my-keyboard-shortcuts-work) + - [Differences compared to Theia?](#differences-compared-to-theia) + - [`$HTTP_PROXY`, `$HTTPS_PROXY`, `$NO_PROXY`](#http_proxy-https_proxy-no_proxy) + - [Enterprise](#enterprise) @@ -354,16 +354,6 @@ The `--config` flag or `$CODE_SERVER_CONFIG` can be used to change the config fi The default location also respects `$XDG_CONFIG_HOME`. -## How do I customize the "Go Home" button? - -You can pass a URL to the `--home` flag like this: - -``` -code-server --home=https://my-website.com -``` - -Or you can define it in the config file with `home`. - ## Isn't an install script piped into sh insecure? Please give diff --git a/src/node/cli.ts b/src/node/cli.ts index 0990797d8..efe3e69e5 100644 --- a/src/node/cli.ts +++ b/src/node/cli.ts @@ -56,7 +56,6 @@ export interface Args extends VsArgs { "new-window"?: boolean link?: OptionalString - home?: string } interface Option { @@ -201,10 +200,6 @@ const options: Options> = { `, beta: true, }, - home: { - type: "string", - description: "Set a custom link for the 'Go Home' button in the Application Menu", - }, } export const optionDescriptions = (): string[] => { diff --git a/test/cli.test.ts b/test/cli.test.ts index 6a0cfd7b6..4614ec381 100644 --- a/test/cli.test.ts +++ b/test/cli.test.ts @@ -55,7 +55,6 @@ describe("parser", () => { "--log", "error", "--help", - "--home=http://localhost:8080/", "--open", "--socket=mumble", "3", @@ -86,7 +85,6 @@ describe("parser", () => { "extra-builtin-extensions-dir": [path.resolve("bazzle")], "extra-extensions-dir": [path.resolve("nozzle")], help: true, - home: "http://localhost:8080/", host: "0.0.0.0", json: true, log: "error",